[PATCH] D131847: Draft: [llvm] Replace uses of llvm::Any with std::any

Joe Loser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 07:18:27 PST 2022


jloser added a comment.

Debating on whether to pursue this patch or not since we have some use of `any_isa` in `llvm` for a "checked" `any_cast` if you will.

In D131847#3977994 <https://reviews.llvm.org/D131847#3977994>, @sebastian-ne wrote:

> I put up D139532 <https://reviews.llvm.org/D139532>, which includes the work done here and finishes it (also replaces any_cast with std::any_cast, compiles and passes llvm and clang tests).

Awesome, thanks! Sorry I never got back around to finishing up this idea - was working on other things. I'll close this review and we can revisit yours once the minimum MSVC version is updated to handle the bug mentioned in your revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131847/new/

https://reviews.llvm.org/D131847



More information about the llvm-commits mailing list