[PATCH] D131296: [PowerPC] Add support for extending and truncating values

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:172
+
+  Register DstReg = I.getOperand(0).getReg();
+  Register SrcReg = I.getOperand(1).getReg();
----------------
Do we need to check if these are valid registers first before getting the register?


================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/ppc-isel-constant.ll:1
+; RUN: llc -mtriple ppc64le-linux -global-isel -o - < %s | FileCheck %s -check-prefixes=CHECK,LINUX
+
----------------
nit: Might be good to autogenerate these LIT tests with `-ppc-asm-full-reg-names`.


================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/ppc-isel-logical.ll:11
 
+; CHECK-LABEL: test_andui32:
+; LINUX: li 5, -1
----------------
nit: Might be good to autogenerate these LIT tests with `-ppc-asm-full-reg-names` here, as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131296/new/

https://reviews.llvm.org/D131296