[PATCH] D139531: [Docs] Update PatFrag definition in documentation

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 06:10:18 PST 2022


asb added inline comments.


================
Comment at: llvm/docs/WritingAnLLVMBackend.rst:1314
 
 In ``lib/Target/TargetSelectionDAG.td``, the DAG operator for store is defined
 below:
----------------
How about "the DAG operator for store is defined below (alongside the definitions it depends on):" so it's less confusing why we're listing `st` and `unindexedstore` as well?

I note that the previous version had `st` without including it's definition, I'm in two minds as to whether it's worth including it (as you do in your patch) or not...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139531/new/

https://reviews.llvm.org/D139531



More information about the llvm-commits mailing list