[PATCH] D139582: [GVN] Improve PRE on load instructions

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 05:23:43 PST 2022


mkazantsev added a comment.

Seems like this patch keeps finding values in vectors, and it might be a reason of CT degradation. Maybe refactor them to be maps instead?



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:926
+static void ReplaceValuesPerBlockEntry(
+    SmallVectorImpl<AvailableValueInBlock> &ValuesPerBlock, BasicBlock *BB,
+    Value *NewValue) {
----------------
`AvailValInBlkVect` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139582/new/

https://reviews.llvm.org/D139582



More information about the llvm-commits mailing list