[PATCH] D139386: [RISCV][THEAD] Vendor extensions: Add 'XTheadVdot' T-Head vendor extensions

Thu Dec 8 05:19:36 PST 2022

JojoR added a comment.

In D139386#3974689 <https://reviews.llvm.org/D139386#3974689>, @reames wrote:

> I have not looked at the change at all (yet), but a couple of high level points.
>
> 1. Please link not to the repository, but a specific version of the PDF.  We need to know exactly what version of the specification is being implemented.  For instance, I was looking at https://github.com/T-head-Semi/thead-extension-spec/releases/download/2.2.0/xthead-2022-12-04-2.2.0.pdf.  Please update RISCVUsage.rst to contain the same information.  This will form the user focused documentation.
>
> 2. Can you clarify whether the extension is based on v1.0 or a prior vector specification revision?  From the document, it looks like this might be based on v1.0.  Getting an extension based off v1.0 into tree will be much easier than one based on v0.7, so being clear is in your interest here.  Ideally, you'd revise the specification document to be explicit here as well.
>
> 3. Please split the patch.  The first patch for review should add the MC (assembly) part only.
>
> 4. I very strongly encourage you to attend the riscv sync up call happening on Thursday of this week.  This will be a likely topic of discussion.

Thanks for your comments and I will attend if I am free at that time :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139386/new/

https://reviews.llvm.org/D139386