[PATCH] D139528: [AsmParser] Check that addrspace fits within 24 bits

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:1812
+    if (!isUInt<24>(AddrSpace))
+      return error(Loc, "invalid address space, must be a 24bit integer");
+    return false;
----------------
Nit: I think "24-bit" would be consistent with similar strings in LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139528/new/

https://reviews.llvm.org/D139528