[PATCH] D139303: [LoongArch] Add custom parser for atomic instructions' memory operand
wanglei via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 8 01:55:55 PST 2022
wangleiat added a comment.
In D139303#3980494 <https://reviews.llvm.org/D139303#3980494>, @xen0n wrote:
> LGTM, thanks!
>
> I've fixed the formatting of the summary for you (the ordered lists can't be used to write Chinese-style paragraphs) while at it.
Thank you very much!
================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchInstPrinter.cpp:64
+ const MCOperand &MO = MI->getOperand(OpNo);
+
+ assert(MO.isReg() && "printAtomicMemOp can only print register operands");
----------------
SixWeining wrote:
> Seems this line is useless.
Thanks, i'll remove it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139303/new/
https://reviews.llvm.org/D139303
More information about the llvm-commits
mailing list