[PATCH] D138645: [AAPointerInfo] rearrange code in preparation for further changes

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 00:24:21 PST 2022


sameerds added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1262
     return true;
   };
 
----------------
jdoerfert wrote:
> sameerds wrote:
> > jdoerfert wrote:
> > > `Ty` can be nullptr, no? Did you test this?
> > At the two calls to this function, I don't see how it can be nullptr. What did I miss?
> If it can't be, make it a reference please.
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138645/new/

https://reviews.llvm.org/D138645



More information about the llvm-commits mailing list