[PATCH] D139403: [SCEV] Compute symbolic exit count for 'and' conditions

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 00:22:07 PST 2022


mkazantsev added inline comments.


================
Comment at: llvm/test/Analysis/ScalarEvolution/symbolic_max_exit_count.ll:560
   %c2 = and i1 %zero_check_2, %scam_2
   %merged_cond = select i1 %c1, i1 true, i1 %c2
   br i1 %merged_cond, label %range_check_block, label %failed_1
----------------
nikic wrote:
> This should be `select i1 %c1, i1 %c2, i1 false`. You made this an or rather than an and.
You're right, what I've done is OR... /facepalm

Let me fix that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139403/new/

https://reviews.llvm.org/D139403



More information about the llvm-commits mailing list