[PATCH] D138238: [SROA] For non-speculatable `load`s of `select`s -- split block, insert then/else blocks, form two-entry PHI node

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/SROA.h:23
 #include "llvm/IR/ValueHandle.h"
+#include <llvm/ADT/MapVector.h>
 #include <vector>
----------------
nit: Wrong include style


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:849
+          .str(),
+      inconvertibleErrorCode());
+}
----------------
Do I understand correctly that this will prevent doing a plain `-passes=sroa` run? If so, please pick one of these as a default -- I don't really care which one, but people who just want to clean up some IR with SROA certainly don't need to know about these details. This would also violate existing practice for all other passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138238/new/

https://reviews.llvm.org/D138238