[PATCH] D139109: [LoopUnswitch] Perform loop unswitching on select instructions

Wed Dec 7 22:56:27 PST 2022

caojoshua added a comment.

In D139109#3978212 <https://reviews.llvm.org/D139109#3978212>, @fhahn wrote:

> It looks like this tries to address the same issue as D138526 <https://reviews.llvm.org/D138526>. Might be goo to sync up with @caojoshua

Can confirm this is addressing the same issue. Our implementations are quite a bit different. It seems you are converting select's into branch's and mostly using existing logic. In my review, I try to directly unswitch the select. Not sure which approach is preferred. I'll let people who have been working on LLVM longer give their thoughts.

Either way, I think we can share some test cases. In my review, I pulled in select tests from the old PM LoopUnswitch pass, and added some checks to existing tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139109/new/

https://reviews.llvm.org/D139109