[PATCH] D139403: [SCEV] Compute symbolic exit count for 'and' conditions

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 22:29:17 PST 2022


mkazantsev updated this revision to Diff 481151.
mkazantsev added a comment.

Rebased on top of more tests with combined arith and logical AND conditions.

As far as I understand the topic, it should be `umin` in `test_two_phis_arithmetic_and` and `umin_seq` in `test_two_phis_logical_and`. In practice it's  `umin_seq` in the former case and nothing in the later.

Do we really want to block the patch on this? Looks like `umin_seq` requires a lot of work to apply where it's really needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139403/new/

https://reviews.llvm.org/D139403

Files:
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/test/Analysis/ScalarEvolution/symbolic_max_exit_count.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139403.481151.patch
Type: text/x-patch
Size: 7188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221208/b1de1855/attachment.bin>


More information about the llvm-commits mailing list