[PATCH] D139549: [X86][ConstraintFP] Model `MXCSR` for function call

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fp-strict-scalar-inttofp-fp16.ll:384
+; SSE2-NEXT:    cvtsi2ss %rcx, %xmm1
+; SSE2-NEXT:    movaps %xmm1, %xmm0
+; SSE2-NEXT:    addss %xmm1, %xmm0
----------------
craig.topper wrote:
> What happened here?
Before this change, `addss` can be sunk into `%bb.1`. But it fails now because of https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/MachineSink.cpp#L918
due to `MXCSR` has a def in this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139549/new/

https://reviews.llvm.org/D139549