[PATCH] D133964: [AMDGPU] Implement dependency heuristic for prioritizing candidate SchedGroups for a given pipeline instruction.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:490
+    // For top-down processing, we want to track the assignments of predecessors
+    for (auto &SuccSU : PipelineSuccs[CurrSyncGroupIdx][SU])
+      PipelineAssignments[CurrSyncGroupIdx][SuccSU].push_back(
----------------
Braces


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:491-492
+    for (auto &SuccSU : PipelineSuccs[CurrSyncGroupIdx][SU])
+      PipelineAssignments[CurrSyncGroupIdx][SuccSU].push_back(
+          std::make_pair(SU, CandSGID));
+  }
----------------
emplace_back?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:622
+    SmallVector<int, 4> DepGroups;
+    // Sort the assigned SG of predecssors in bottom-up order
+    for (auto &Assignment :
----------------
spell out SG?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133964/new/

https://reviews.llvm.org/D133964