[PATCH] D139367: [CSSPGO][llvm-profgen] Missing frame inference.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:460
                  FunctionSamples::getCanonicalFnName(Symbols[SI].Name));
-
+  FuncRange *FRange = findFuncRange(StartAddress);
   StringRef SymbolName =
----------------
wlei wrote:
> Nit: `findFuncRange` is also called inside `setIsFuncEntry`, perhaps we could hoist and reuse that, this should save some running time.
Good point, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139367/new/

https://reviews.llvm.org/D139367