[PATCH] D139587: [NFC] Expose Time Profile utilities for easier reuse

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Let's address these issues first and then we look again.



================
Comment at: llvm/include/llvm/Support/TimeProfiler.h:98
 
-struct TimeTraceProfiler;
+struct Entry {
+  const TimePointType Start;
----------------
`llvm::Entry` is not a great way to export this.
Rename it, put it into a namespace, or make it part of the TimeTraceProfiler. The last option is probably the nicest.
You also managed to delete the few comments, e.g. for the Entry class, and down below introduces a typo (or reverted a fix for it).


================
Comment at: llvm/include/llvm/Support/TimeProfiler.h:211
+};
+static TimeTraceProfilerInstances Instances;
+TimeTraceProfilerInstances &getTimeTraceProfilerInstances();
----------------
This doesn't need to be exposed. That's what the getter is for.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139587/new/

https://reviews.llvm.org/D139587