[PATCH] D139418: [AArch64] GlobalIsel codegen for gpr CTZ

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:78
   // support.
   const bool HasFP16 = ST.hasFullFP16();
   const LLT &MinFPScalar = HasFP16 ? s16 : s32;
----------------
I think the `HasCSSC` variable should go somewhere around here so that we can avoid moving it around as you add support for the CSSC feature.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:667
 
+  bool HasCSSC = ST.hasCSSC();
   getActionDefinitionsBuilder(G_CTTZ)
----------------
You have a bunch of changes which declare this variable/move it around.

How about just moving it to the top of this function so that you don't have to move it every time?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139418/new/

https://reviews.llvm.org/D139418