[PATCH] D139420: [AArch64] implement GPR (U/S)(MIN/MAX) instruction GISel support

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:954
+  /// Conditionally limit the minimum size of the scalar.
+  LegalizeRuleSet &minScalarIf(LegalityPredicate Predicate, unsigned TypeIdx,
+                               const LLT Ty) {
----------------
Can you add a test for this function in `llvm/unittests/CodeGen/GlobalISel/LegalizerInfoTest.cpp`?

Then maybe split this into two patches:

Patch 1: Add `minScalarIf`
Patch 2: Add the new lowering


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139420/new/

https://reviews.llvm.org/D139420