[PATCH] D123284: [ArgPromotion][Attributor] Update min-legal-vector-width when do promotion

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 13:52:30 PST 2022


arsenm reopened this revision.
arsenm added a comment.

This should not have landed without additional review. I have raised some issues at

https://reviews.llvm.org/rG7c04454227f5c6bd3f515783950a815970c90558



================
Comment at: llvm/docs/LangRef.rst:2193-2194
+    This attribute indicates the minimum legal vector width required by the
+    calling conversion. It is the maximum width of vector arguments and
+    returnings in the function and functions called by this function. Because
+    all the vectors are supposed to be legal type for compatibility.
----------------
This is an unreasonable expectation for an attribute and 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123284/new/

https://reviews.llvm.org/D123284



More information about the llvm-commits mailing list