[PATCH] D139572: [lld-macho] Fix bug in reading cpuSubType field.

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 13:27:29 PST 2022


int3 added a comment.

Is there a test we could write here? How do the other bits in cpusubtype get set?



================
Comment at: lld/MachO/InputFiles.cpp:234
 
-    if (read32be(&arch[i].cputype) != static_cast<uint32_t>(target->cpuType) ||
-        read32be(&arch[i].cpusubtype) != target->cpuSubtype)
+    uint32_t cuptype = read32be(&arch[i].cputype);
+    uint32_t cpusubtype =
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139572/new/

https://reviews.llvm.org/D139572



More information about the llvm-commits mailing list