[PATCH] D139559: [lld/mac] Abort link immediately on invalid -undefined argument

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/Driver.cpp:1611-1612
   config->undefinedSymbolTreatment = getUndefinedSymbolTreatment(args);
+  if (errorCount())
+    return false;
 
----------------
how about changing the `error()` call in `getUndefinedSymbolTreatment` to `fatal()` instead? That way the motivation for the early exit is clearer + we won't accidentally apply this early exit to other error messages in the future


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139559/new/

https://reviews.llvm.org/D139559