[PATCH] D139335: [BOLT] Fix blocks layout reverse iterators

[Amir Ayupov via Phabricator via llvm-commits]

Amir added a comment.

In D139335#3979241 <https://reviews.llvm.org/D139335#3979241>, @yota9 wrote:

> Thanks @Amir I'm not that deep in the C++ to be honest, but it looks OK. But I still have some problems using these iterators with this patch, resulting in SIGSEGV :( I've found out that if I replace (addition to this patch):
>
> 1. In class FunctionFragment iterator types to
>
>   using iterator = BasicBlockListType::iterator;
>
>   using const_iterator = BasicBlockListType::const_iterator;
> 2. In class FunctionLayout
>
>   using block_const_iterator = BasicBlockListType::const_iterator;
>
> Everything works fine. What do you think about it?

I'm not an expert either. Your proposed changes make sense to me, submit them as a diff and I'll test it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139335/new/

https://reviews.llvm.org/D139335