[PATCH] D139465: GISel/Combiner: maintain created instructions in a SetVector

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 12:41:15 PST 2022


nhaehnle added a comment.

In D139465#3977195 <https://reviews.llvm.org/D139465#3977195>, @foad wrote:

> LGTM. Could put the declaration inside `#ifndef NDEBUG`.

This is in a .cpp file, so not part of the ABI, so that seems perfectly safe. Good idea!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139465/new/

https://reviews.llvm.org/D139465



More information about the llvm-commits mailing list