[PATCH] D139335: [BOLT] Fix blocks layout reverse iterators

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 12:33:23 PST 2022


yota9 added a comment.

Thanks @Amir I'm not that deep in the C++ to be honest, but it looks OK. But I still have some problems using these iterators with this patch, resulting in SIGSEGV :( I've found out that if I replace:

1. In class FunctionFragment iterator types to using iterator = BasicBlockListType::iterator; using const_iterator = BasicBlockListType::const_iterator;
2. In class FunctionLayout using block_const_iterator = BasicBlockListType::const_iterator;

Everything works fine. What do you think about it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139335/new/

https://reviews.llvm.org/D139335



More information about the llvm-commits mailing list