[PATCH] D137632: [LoopPredication] Widen checks if condition operands constant ranges are known

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 11:30:54 PST 2022


apilipenko added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:817-831
+  switch (Pred) {
+  case CmpInst::ICMP_EQ:
+  case CmpInst::ICMP_NE:
+    LLVM_DEBUG(dbgs() << "Unsupported predicate\n");
+    return None;
+  case CmpInst::ICMP_UGT:
+  case CmpInst::ICMP_UGE:
----------------
apilipenko wrote:
> Please, spell the list of supported predicated explicitly here. 
Could you please, spell the list of *supported* predicates explicitly? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137632/new/

https://reviews.llvm.org/D137632



More information about the llvm-commits mailing list