[PATCH] D139467: AMDGPU: Add AMDGPUSubtarget::getEUsPerCU()

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h:213
 
+  // Number of SIMDs per "CU", where the "CU" is the unit onto which workgroups
+  // are mapped. This takes WGP mode vs. CU mode into account.
----------------
foad wrote:
> Since "CU" is misleading, can you think of a better name for "unit onto which workgroups are mapped"?
I was wondering this as well and am open to suggestions.

Work Group Processor obviously doesn't work.

Work Group Compute Unit (WGCU)? Work Group Unit (WGU)? Work Group Execution Unit (WGEU)? (And make the EU a Wave Execution Unit?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139467/new/

https://reviews.llvm.org/D139467