[PATCH] D138832: [llvm-exegesis][x86] Add option to prevent use of xmm8-xmm15 upper SSE registers

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/Target.cpp:41-42
 
 static cl::OptionCategory
     BenchmarkOptions("llvm-exegesis benchmark x86-options");
 
----------------
RKSimon wrote:
> lebedev.ri wrote:
> > FYI this doesn't work. You probably want to expose the declaration of
> > the normal `BenchmarkOptions` in a header and use it,
> > not add a new group, because it isn't being displayed.
> > Maybe other tools have some other example on how to handle this.
> > 
> Cheers, I'll take a look as a follow up - you've probably guessed I was just doing an copy+paste of the lbr option :) 
Yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138832/new/

https://reviews.llvm.org/D138832