[PATCH] D136310: [SPIR-V] Add atomic_flag builtin implementation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp:438-440
+  unsigned Semantics =
+      getSPIRVMemSemantics(Order) |
+      getMemSemanticsForStorageClass(GR->getPointerStorageClass(PtrRegister));
----------------
Why is this something that would be materialized in a register instead of an immediate argument?


================
Comment at: llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp:445
+
+  return Register(0);
+}
----------------
Don't need the 0


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136310/new/

https://reviews.llvm.org/D136310