[PATCH] D139403: [SCEV] Compute symbolic exit count for 'and' conditions

Wed Dec 7 06:44:35 PST 2022

nikic added a comment.

In D139403#3977959 <https://reviews.llvm.org/D139403#3977959>, @mkazantsev wrote:

> I've added a test which I think should end up with umin_seq, but it's umin. I don't know why, maybe a bug?

Indeed, we were missing a umin_seq when computing the symbolic max BE count. Fixed in https://github.com/llvm/llvm-project/commit/4d97a914d7aef6c95cd95669f99e5d32899e165a.

However, this indicates that this test is still not covering the right code path: I think what you need is a nested `(A1 and A2) and (B1 and B2)` structure where we get symbolic counts `C1` and `C2` from the inner ands and then those get combined. That will give you the umin from the new code path.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139403/new/

https://reviews.llvm.org/D139403