[PATCH] D139536: [runtimes] Don't override LLVM_ENABLE_PER_TARGET_RUNTIME_DIR set from llvm

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 06:37:02 PST 2022


DavidSpickett added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:78
                                       -DLLVM_DEFAULT_TARGET_TRIPLE=${LLVM_TARGET_TRIPLE}
-                                      -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default}
                                       -DCMAKE_C_COMPILER_WORKS=ON
----------------
I don't know why the `_default` variable was used here, I don't think it matters too much.

With this change, if you add `-DLLVM_ENABLE_PER...` to your cmake command line, it will be passed down to this function as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139536/new/

https://reviews.llvm.org/D139536



More information about the llvm-commits mailing list