[PATCH] D139536: [runtimes] Don't override LLVM_ENABLE_PER_TARGET_RUNTIME_DIR set from llvm

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 06:32:49 PST 2022


DavidSpickett added reviewers: phosek, MaskRay.
DavidSpickett added a comment.
Herald added a subscriber: StephenFan.

Background is that I'm using the release build script to test the new library layout for armhf, and first step to that was getting a working build without any changes.

I have left the functions that do `=ON` alone, though maybe they need this check too. I didn't hit them in the builds I've tried.

The other thing I don't know is if we should be putting the same opt out/ins in llvm and runtimes for this setting. llvm turns it ON for BSD or Linux, except when it's on Arm. runtimes disables it for AIX. Perhaps they could be shared?

Problem with that is that I think you can build without using only the runtimes cmake, is that the case? If so, you'd need to have the opt in/outs in both places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139536/new/

https://reviews.llvm.org/D139536



More information about the llvm-commits mailing list