[PATCH] D139529: [mlir][NFC] Add a new getStridesAndOffset function

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet created this revision.
qcolombet added reviewers: ftynse, nicolasvasilache, jreiffers.
qcolombet added a project: MLIR.
Herald added subscribers: Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
Herald added a reviewer: rriddle.
Herald added a project: All.
qcolombet requested review of this revision.
Herald added a subscriber: stephenneuendorffer.
Herald added a reviewer: dcaballe.

The new function is a wrapper around the regular `getStridesAndOffset` that offers a more compact way (as in writing less code) of getting the relevant information.

This method is intended to be used only when it is known that the LogicalResult of the regular `getStridesAndOffset` must be "succeeded".

This wrapper will assert on that.

Note: I feel we may want to give this function a different name so that it is explicit that it should be used only when we know it is valid. I couldn't come up with a good name though. What do people think?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139529

Files:
  mlir/include/mlir/IR/BuiltinTypes.h
  mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp
  mlir/lib/Conversion/LLVMCommon/Pattern.cpp
  mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
  mlir/lib/Dialect/MemRef/Transforms/ExpandStridedMetadata.cpp
  mlir/lib/IR/BuiltinTypes.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139529.480845.patch
Type: text/x-patch
Size: 7254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221207/aaea5508/attachment.bin>