[PATCH] D139527: [AMDGPU] Use SOP_Pseudo more consistently. NFC.

[Jay Foad via Phabricator via llvm-commits]

foad created this revision.
foad added reviewers: AMDGPU, dp.
Herald added subscribers: kosarev, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

SOPK_Pseudo was not inheriting from SOP_Pseudo at all, and some other
Pseudo classes were needlessly redefining things that were already
defined by SOP_Pseudo.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139527

Files:
  llvm/lib/Target/AMDGPU/SOPInstructions.td


Index: llvm/lib/Target/AMDGPU/SOPInstructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/SOPInstructions.td
+++ llvm/lib/Target/AMDGPU/SOPInstructions.td
@@ -51,7 +51,7 @@
   let UseNamedOperandTable = 1;
 
   bits<1> has_src0 = 1;
-  bits<1> has_sdst = 1;
+  let has_sdst = 1;
 }
 
 class SOP1_Real<bits<8> op, SOP1_Pseudo ps, string real_name = ps.Mnemonic> :
@@ -722,10 +722,7 @@
 
 class SOPK_Pseudo <string opName, dag outs, dag ins,
                    string asmOps, list<dag> pattern=[]> :
-  InstSI <outs, ins, "", pattern>,
-  SIMCInstr<opName, SIEncodingFamily.NONE> {
-  let isPseudo = 1;
-  let isCodeGenOnly = 1;
+  SOP_Pseudo<opName, outs, ins, " " # asmOps, pattern> {
   let mayLoad = 0;
   let mayStore = 0;
   let hasSideEffects = 0;
@@ -734,10 +731,8 @@
   let FixedSize = 1;
   let SchedRW = [WriteSALU];
   let UseNamedOperandTable = 1;
-  string Mnemonic = opName;
-  string AsmOperands = " " # asmOps;
 
-  bits<1> has_sdst = 1;
+  let has_sdst = 1;
 }
 
 class SOPK_Real<SOPK_Pseudo ps> :
@@ -1113,8 +1108,6 @@
                   string sep = !if(!empty(asmOps), "", " "),
                   string keyName = opName> :
   SOP_Pseudo<opName, (outs), ins, sep # asmOps, pattern> {
-  let isPseudo = 1;
-  let isCodeGenOnly = 1;
   let mayLoad = 0;
   let mayStore = 0;
   let hasSideEffects = 0;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139527.480841.patch
Type: text/x-patch
Size: 1374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221207/6d1fa847/attachment.bin>