[PATCH] D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj

Wed Dec 7 02:31:40 PST 2022

Esme added a comment.

Feel sorry that i'm just getting started to review this patch.
I've applied the patch and test the functionality and it looks good overall. Thanks.
However, considering the printing format of relocations in llvm-readobj, when `--expand-relocs` is not specified, we usually print relocations in this format:

  vaddr     section    type   symbol
  20000294    2       POS   .data
  2000029c    2       POS   0

Only when `--expand-relocs` is specified, we print relocations like the format in this patch.
The `--dyn-relocations` option also follows such rule.

================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:243
+  support::big32_t SymbolIndex;
+};
+
----------------
I noticed an extra field of `l_value` for Loader Section Relocation Table Entry Structure specified by the doc, is it also a doc error?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136787/new/

https://reviews.llvm.org/D136787