[PATCH] D139381: Added a C-API binding to query the LLVM version

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm-c/Core.h:490
+ */
+void LLVMGetVersion(unsigned *major, unsigned *minor, unsigned *patch);
+
----------------
nit: Variable names should be upper case.


================
Comment at: llvm/unittests/IR/CoreBindings.cpp:16
+TEST(CoreBindings, VersionTest) {
+
+  // Test ability to ignore output parameters
----------------
nit: Unnecessary newline.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139381/new/

https://reviews.llvm.org/D139381