[PATCH] D139254: Enhance stack protector

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added a comment.

In D139254#3974001 <https://reviews.llvm.org/D139254#3974001>, @alexfh wrote:

> There's a problem in the previous iteration of this patch (https://reviews.llvm.org/D138774). It made clang hang while compiling the following short snippet reduced from an open-source library (compiled on x86-64, linux):
>
>   $ cat q.c
>   char *texsubexpr(char *expression, char *subexpr) {
>     char *texchar();
>     if (*expression) return texchar(expression, subexpr);
>   }
>   
>   void __stack_chk_fail (void) {
>     __builtin_trap ();
>   }
>   
>   $ clang -O1  -w -fstack-protector-all   -c q.c  -o q.o
>
> Please ensure this is solved here.

Fix/Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139254/new/

https://reviews.llvm.org/D139254