[PATCH] D139254: Enhance stack protector
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 6 17:40:57 PST 2022
xiangzhangllvm added a comment.
In D139254#3974001 <https://reviews.llvm.org/D139254#3974001>, @alexfh wrote:
> There's a problem in the previous iteration of this patch (https://reviews.llvm.org/D138774). It made clang hang while compiling the following short snippet reduced from an open-source library (compiled on x86-64, linux):
I check it, the clang still hang, let me check and fix it. Thanks very much!
================
Comment at: llvm/test/CodeGen/X86/stack-protector-no-return.ll:5
+; Function Attrs: sspreq
+define void @_Z7catchesv() #0 personality i8* null {
+; CHECK-LABEL: _Z7catchesv:
----------------
There is a fail (about dominate tree checking) for this test at https://reviews.llvm.org/D138774 ,current patch fix it and then, to let it be more clear, I use llvm-reduce simplify it.
(Now, both the old version and new version of this test are pass)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139254/new/
https://reviews.llvm.org/D139254
More information about the llvm-commits
mailing list