[PATCH] D139488: [Target] Pass object reference into initializers in object constructors

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:32
 
-IFSStubTriple::IFSStubTriple(IFSStubTriple const &Stub) : IFSStub() {
+IFSStubTriple::IFSStubTriple(IFSStubTriple const &Stub) : IFSStub(Stub) {
   IfsVersion = Stub.IfsVersion;
----------------
IFSStubTriple inherits from IFSStub and appears to have the unneeded constructor.


================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:519
 
-  AArch64Operand(const AArch64Operand &o) : MCParsedAsmOperand(), Ctx(o.Ctx) {
+  AArch64Operand(const AArch64Operand &o) : MCParsedAsmOperand(o), Ctx(o.Ctx) {
     Kind = o.Kind;
----------------
This initializes the unused fields in the base class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139488/new/

https://reviews.llvm.org/D139488