[PATCH] D139214: [BOLT][DWARF] Don't create extra .debug_str_offsets contributions

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo marked 3 inline comments as done.
ayermolo added inline comments.


================
Comment at: bolt/lib/Core/DebugData.cpp:1095
+      findAttributeInfo(Unit.getUnitDIE(), dwarf::DW_AT_str_offsets_base);
+  assert(AttrVal && "DW_AT_str_offsets_base not present.");
+  Optional<uint64_t> Val = AttrVal->V.getAsSectionOffset();
----------------
maksfb wrote:
> Is this an assert on internal condition or is it the input validation?
Internal state. In case this somehow gets called in DWARF4 or something.


================
Comment at: bolt/lib/Core/DebugData.cpp:1110-1111
+  }
+  // Will assert if we already processed this contribution, and now skipping it,
+  // but it was modified.
+  assert(RetVal.second ||
----------------
maksfb wrote:
> When can this happen?
In theory, if two DWO CUs share same entry (built with ThinLTO). From what I have seen they do not, since compilation directory is different, but who knows in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139214/new/

https://reviews.llvm.org/D139214