[PATCH] D139483: Reserve memory before pushing back
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 6 16:30:15 PST 2022
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-cov/CoverageReport.cpp:405
FileReports.emplace_back(Filename.drop_front(LCP));
- Pool.async(&CoverageReport::prepareSingleFileReport, Filename,
- &Coverage, Options, LCP, &FileReports.back(), &Filters);
+ Pool.async(&CoverageReport::prepareSingleFileReport, Filename, &Coverage,
+ Options, LCP, &FileReports.back(), &Filters);
----------------
Drop unneeded change
================
Comment at: llvm/tools/llvm-cov/CoverageReport.cpp:441
+ Filenames.reserve(FileReports.size());
+for (const FileCoverageSummary &FCS : FileReports)
Filenames.emplace_back(FCS.Name);
----------------
wrong indentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139483/new/
https://reviews.llvm.org/D139483
More information about the llvm-commits
mailing list