[PATCH] D139449: [ObjYAML] Pass 10 instead of 16 for strncmp

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 16:28:11 PST 2022


MaskRay added a comment.

No. strcmp must take strings (NUL-terminated) as arguments. strncmp can work on possibly NUL-terminated arrays. 16 is correct and there is little point changing it since segname has 16 bytes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139449/new/

https://reviews.llvm.org/D139449



More information about the llvm-commits mailing list