[PATCH] D139209: [IRMover] Remove UB implying parameter attributes when necessary
Tim Neumann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 6 13:12:00 PST 2022
TimNN updated this revision to Diff 480592.
TimNN added a comment.
Address review comments
- Move the fixup to after the existing `if`.
- Only perform the fixup when the source is a definition and the destination a declaration.
- Change the test to contain the post-deadargelim IR.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139209/new/
https://reviews.llvm.org/D139209
Files:
llvm/include/llvm/IR/Attributes.h
llvm/lib/Linker/IRMover.cpp
llvm/test/Transforms/FunctionImport/Inputs/attr_fixup.ll
llvm/test/Transforms/FunctionImport/attr_fixup.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139209.480592.patch
Type: text/x-patch
Size: 6403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221206/95255d73/attachment-0001.bin>
More information about the llvm-commits
mailing list