[PATCH] D139449: [ObjYAML] Pass 10 instead of 16 for strncmp

[Alf via Phabricator via llvm-commits]

gAlfonso-bit created this revision.
gAlfonso-bit added a project: LLVM.
Herald added a subscriber: hiraditya.
Herald added a project: All.
gAlfonso-bit requested review of this revision.
Herald added a subscriber: llvm-commits.

When you do a strncmp with an n value larger than the 11 character string literal, you may as well do strcmp.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139449

Files:
  llvm/lib/ObjectYAML/MachOEmitter.cpp


Index: llvm/lib/ObjectYAML/MachOEmitter.cpp
===================================================================
--- llvm/lib/ObjectYAML/MachOEmitter.cpp
+++ llvm/lib/ObjectYAML/MachOEmitter.cpp
@@ -301,7 +301,7 @@
       uint64_t segOff = is64Bit ? LC.Data.segment_command_64_data.fileoff
                                 : LC.Data.segment_command_data.fileoff;
       if (0 ==
-          strncmp(&LC.Data.segment_command_data.segname[0], "__LINKEDIT", 16)) {
+          strncmp(&LC.Data.segment_command_data.segname[0], "__LINKEDIT", 10)) {
         FoundLinkEditSeg = true;
         LinkEditOff = segOff;
         if (Obj.RawLinkEditSegment)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139449.480565.patch
Type: text/x-patch
Size: 644 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221206/8e98b1b1/attachment.bin>