[PATCH] D105067: [SystemZ] Emit .gnu_attribute for an externally visible vector abi.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 10:11:50 PST 2022


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

See one inline comment, otherwise LGTM now.   Thanks!



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7628
   CharUnits DirectAlign;
+  SZCGI.handleExternallyVisibleObjABI(Ty.getTypePtr(), CGF.CGM);
   if (IsIndirect) {
----------------
Just one minor nit: why use `CGF.CGM` in some places and `CGT.getCGM()` in others?  These should be the same, but it would be clearer to use the same expression everywhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105067/new/

https://reviews.llvm.org/D105067



More information about the llvm-commits mailing list