[PATCH] D138906: [SVE] Commonise bfmlal* and fmlal* instruction classes

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 09:51:16 PST 2022


paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

A minor request and the patch likely needs rebasing but other it looks good to me.



================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:2591
 
-multiclass sve2_fp_mla_long<bits<2> opc, string asm, SDPatternOperator op> {
+multiclass sve2_fp_mla_long<bits<3> opc, string asm, ValueType OutVT, ValueType InVT, SDPatternOperator op> {
   def NAME : sve2_fp_mla_long<opc, asm>;
----------------
Please can you reformat this to be within the 80 character line length limit.  We don't typically have a rule for td files other than for the class definitions where we try to follow the same rule as with function signatures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138906/new/

https://reviews.llvm.org/D138906



More information about the llvm-commits mailing list