[PATCH] D139439: [Alignment][NFC] Use Align in MCStreamer emitZeroFill/emitLocalCommonSymbol

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 08:58:06 PST 2022


gchatelet created this revision.
gchatelet added a reviewer: courbet.
Herald added subscribers: pmatos, asb, ThomasRaoux, gbedwell, hiraditya, sbc100.
Herald added a reviewer: andreadb.
Herald added a project: All.
gchatelet requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Before performing this change, I checked that `ByteAlignment` was never `0` inside `MCAsmStreamer:emitZeroFill` and `MCAsmStreamer::emitLocalCommonSymbol`.
I believe it is NFC as `0` values are illegal in `emitZeroFill` anyways, `Log2(ByteAlignment)` would be undefined.
And currently, all calls to `emitLocalCommonSymbol` are provably `>0`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139439

Files:
  llvm/include/llvm/MC/MCDXContainerStreamer.h
  llvm/include/llvm/MC/MCELFStreamer.h
  llvm/include/llvm/MC/MCSPIRVStreamer.h
  llvm/include/llvm/MC/MCStreamer.h
  llvm/include/llvm/MC/MCWasmStreamer.h
  llvm/include/llvm/MC/MCWinCOFFStreamer.h
  llvm/include/llvm/MC/MCXCOFFStreamer.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/lib/MC/MCMachOStreamer.cpp
  llvm/lib/MC/MCNullStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/DarwinAsmParser.cpp
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/lib/MC/MCStreamer.cpp
  llvm/lib/MC/MCWasmStreamer.cpp
  llvm/lib/MC/MCWinCOFFStreamer.cpp
  llvm/lib/MC/MCXCOFFStreamer.cpp
  llvm/lib/Object/RecordStreamer.cpp
  llvm/lib/Object/RecordStreamer.h
  llvm/tools/llvm-exegesis/lib/SnippetFile.cpp
  llvm/tools/llvm-mca/CodeRegionGenerator.cpp
  llvm/unittests/CodeGen/TestAsmPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139439.480510.patch
Type: text/x-patch
Size: 22329 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221206/81a59cf7/attachment.bin>


More information about the llvm-commits mailing list