[PATCH] D139184: [LLD][Windows]Feature "checksum" for Windows PE

[Tobias Hieta via Phabricator via llvm-commits]

thieta accepted this revision.
thieta added a comment.
This revision is now accepted and ready to land.

Looks good to me!



================
Comment at: lld/COFF/Writer.cpp:603
 
+void Writer::writePEChecksum() {
+  if (!config->writeCheckSum) {
----------------
I am a little surprised that we don't have a function for calculating this checksum already. We are not duplicating code with this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139184/new/

https://reviews.llvm.org/D139184