[PATCH] D139119: [AArch64][SVE2p1] Make use of REVD instruction.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 07:43:33 PST 2022


sdesmalen marked an inline comment as done.
sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:23177-23178
 
+  if (Subtarget->hasSVE2p1() && isREVMask(ShuffleMask, VT, 128) &&
+      VT.getScalarSizeInBits() == 64) {
+    if (!VT.isFloatingPoint())
----------------
paulwalker-arm wrote:
> Perhaps worth putting `VT.getScalarSizeInBits() == 64` before the called to `isREVMask` so we bail out earlier.
good point, I've done that before committing!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139119/new/

https://reviews.llvm.org/D139119



More information about the llvm-commits mailing list