[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 06:41:53 PST 2022


paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1517
 
-class SVE_4Vec_BF16_Indexed
+class SVE_4Vec_BF16_Indexed_V2
     : DefaultAttrsIntrinsic<[llvm_nxv4f32_ty],
----------------
I suppose you don't actually need to change the name of this class.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3977
+    LLVMContext &Ctx = F->getParent()->getContext();
+    SmallVector<Value *, 2> Args(CI->args());
+    Args[3] = ConstantInt::get(Type::getInt32Ty(Ctx),
----------------
This may as well be 4 given we know the exact number of arguments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138788/new/

https://reviews.llvm.org/D138788



More information about the llvm-commits mailing list