[PATCH] D138778: Output alignment in zerofill and comm only if needed

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added a comment.

In D138778#3969603 <https://reviews.llvm.org/D138778#3969603>, @MaskRay wrote:

> Sorry for the belated response. This change looks wrong. Without the third argument, the alignment appears `min(st_size, 16)` on ELF in GNU as.
>
> alignment=1 (st_value=1) COMMON symbols will get wrong alignments.

Thx ! Is there a reason to differentiate between 0 and 1 here ? Would that be OK to output alignment unconditionally ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138778/new/

https://reviews.llvm.org/D138778